Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add model validation #35

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

jpgtzg
Copy link
Contributor

@jpgtzg jpgtzg commented Feb 3, 2025

Description

  • Implemented a new feature that validates any Experience, Skill or Education added
  • Returns a JSON response with the validated data or error

Changes Made

  • Implemented a validation function for all models, it is automatically called when making a POST request to any /education, /skill, or /experience endpoint

Testing

  • Verified the new endpoint
  • Confirmed the endpoint works with all models

Issues

Copy link
Collaborator

@Pradyuman7 Pradyuman7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing for this PR, let's keep the PRs independent so it's easier to review

@jpgtzg jpgtzg force-pushed the feature/add-model-validation branch from 758380c to 50c6a26 Compare February 5, 2025 13:24
@jpgtzg
Copy link
Contributor Author

jpgtzg commented Feb 5, 2025

There we go @Pradyuman7, fixed it!

@jpgtzg jpgtzg requested a review from Pradyuman7 February 5, 2025 13:25
Copy link
Collaborator

@Pradyuman7 Pradyuman7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@Pradyuman7
Copy link
Collaborator

@jpgtzg please resolve the conflicts and then feel free to merge

@jpgtzg jpgtzg force-pushed the feature/add-model-validation branch from 8945ca3 to 50c6a26 Compare February 7, 2025 16:38
@jpgtzg
Copy link
Contributor Author

jpgtzg commented Feb 7, 2025

@Pradyuman7 ready!

@Pradyuman7 Pradyuman7 merged commit 63a18b3 into MLH-Fellowship:main Feb 7, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation that POST requests are in the correct format
2 participants