Feature/Delete an existing experience #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FortunateOmonuwa
changed the title
FortunateOmonuwa
changed the title
FortunateOmonuwa
changed the title
Pradyuman7
reviewed
Feb 6, 2025
app.py
Outdated
| return jsonify({"message": "Resource doesn't exist"}), 404 | ||
| else: | ||
| deleted_exp = data['experience'].pop(exp_id) | ||
| # return jsonify({"message": "Experience Successfully Deleted", "deleted_experience": deleted_exp}), 200 |
There was a problem hiding this comment.
Let's remove this comment if it's not needed
app.py
Outdated
| # return jsonify({"message": "Experience Successfully Deleted", "deleted_experience": deleted_exp}), 200 | ||
| return jsonify({"message": "Experience Successfully Deleted"}), 200 | ||
| except Exception as e: | ||
| print(f"Error :{e} ") |
There was a problem hiding this comment.
Let' not include prints in production code
app.py
Outdated
| return jsonify({"error": "An error occured"}), 500 | ||
|
|
||
|
|
||
| @app.route('/resume/education', methods=['GET', 'POST']) |
There was a problem hiding this comment.
Please are you referring to: "@app.route('/resume/education', methods=['GET', 'POST'])"
or this: "return jsonify({"error": "An error occured"}), 500"
There was a problem hiding this comment.
"@app.route('/resume/education', methods=['GET', 'POST'])" mainly. Is this required here?
Pradyuman7
reviewed
Feb 6, 2025
| @@ -34,6 +34,34 @@ def test_experience(): | |||
| assert response.json[item_id] == example_experience | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Why is this all commented out? You can remove this test since the post endpoint is not there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Pradyuman7