Feature/Delete an existing skill #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pradyuman7
approved these changes
Feb 9, 2025
There was a problem hiding this comment.
LGTM 💯 we'll merge this after education so there is no duplicate stuff.
Btw, it is generally a better practice to keep PRs independent of each other if you're merging them to the same branch (i.e. main). This shows only the relevant code of the PR and makes it easier to review
Pradyuman7
reviewed
Feb 9, 2025
app.py
Outdated
| @@ -58,27 +58,39 @@ def experience(index=None): | |||
| return jsonify({"error": "Experience not found"}), 404 | |||
| return jsonify(data["experience"]), 200 | |||
|
|
|||
| if request.method == 'POST': | |||
| json_data = request.json | |||
| if request.method == "POST": | |||
There was a problem hiding this comment.
This should not be updated in this PR
FortunateOmonuwa
force-pushed
the
delete_existing_skill
branch
from
75d6824 to
7cdf0ba
Compare
FortunateOmonuwa
force-pushed
the
delete_existing_skill
branch
from
cda6eb8 to
c03602a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Pradyuman7