Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appended drop down for language support increasing accessibility by multi lingual language support #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shivamsingh124
Copy link
Collaborator

image
Adding the drop-down for language support using Google translate API (GTTS)

@netlify
Copy link

netlify bot commented Mar 24, 2022

Deploy Preview for mlh-prep-march-2022 ready!

Name Link
🔨 Latest commit 5382abf
🔍 Latest deploy log https://app.netlify.com/sites/mlh-prep-march-2022/deploys/623cb43d27d59300093c049d
😎 Deploy Preview https://deploy-preview-43--mlh-prep-march-2022.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shivamsingh124
Copy link
Collaborator Author

FIX #39

Copy link
Collaborator

@marcnjaramillo marcnjaramillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding language support. It's a nice feature to have. I've requested a few changes, so once you get those taken care of it will be ready to merge. Could you also remove package-lock.json and make sure to use yarn install?

@@ -0,0 +1,8 @@

const languagesupport = ({ setCity }) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency in naming conventions, please change this to LanguageSupport and MultiLanguage/LanguageSupport.js.

@shivamsingh124
Copy link
Collaborator Author

Thank you for adding language support. It's a nice feature to have. I've requested a few changes, so once you get those taken care of it will be ready to merge. Could you also remove package-lock.json and make sure to use yarn install?

Yes sure @marcnjaramillo , actually I removed yarn when I was having issue while running the code in my local host. I will make the changes soon

@shivamsingh124
Copy link
Collaborator Author

Thank you for adding language support. It's a nice feature to have. I've requested a few changes, so once you get those taken care of it will be ready to merge. Could you also remove package-lock.json and make sure to use yarn install?

I am working on resolving this issue, but the UI loading is having an issue I am getting a blue background only. and there are conflicts in my file, which I am trying to figure out. It will take some time, I will try to do it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants