-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appended drop down for language support increasing accessibility by multi lingual language support #43
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for mlh-prep-march-2022 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
FIX #39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding language support. It's a nice feature to have. I've requested a few changes, so once you get those taken care of it will be ready to merge. Could you also remove package-lock.json
and make sure to use yarn install
?
@@ -0,0 +1,8 @@ | |||
|
|||
const languagesupport = ({ setCity }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency in naming conventions, please change this to LanguageSupport
and MultiLanguage/LanguageSupport.js
.
Yes sure @marcnjaramillo , actually I removed yarn when I was having issue while running the code in my local host. I will make the changes soon |
I am working on resolving this issue, but the UI loading is having an issue I am getting a blue background only. and there are conflicts in my file, which I am trying to figure out. It will take some time, I will try to do it ASAP. |
Adding the drop-down for language support using Google translate API (GTTS)