forked from ianstormtaylor/slate
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from ianstormtaylor:main #67
Open
pull
wants to merge
243
commits into
MLH-Fellowship:main
Choose a base branch
from
ianstormtaylor:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat * fix * Create two-books-bow.md * docs * feat * fix
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…morphicLayoutEffect (#5313)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Allow consumer handling of `onInput` event * Avoid restoring the DOM for characterData mutations
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix: cancel debounced listeners in Editable * fix: add change set
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.8. - [Release notes](https://github.com/minimistjs/minimist/releases) - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md) - [Commits](minimistjs/minimist@v1.2.5...v1.2.8) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ween Chrome versions 60-75 on the Android platform. (#5327) * fix: The issue of composition API and beforeinput event triggering between Chrome versions 60-75 on the Android platform. * feat: add changeset * fix: update the logic of HAS_BEFORE_INPUT_SUPPORT
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
… when use image(void) element (#5344) Co-authored-by: linqirong <[email protected]>
The node name should be `STRONG` instead of `strong` in the example deserialize function.
* fixes android input events in mention example Android keyboards use a composition text approach for autocomplete purposes. Chrome sees the mention text and thinks it is part of the word to complete. The simplest solution is to add zero width whitespace. This also adds a click handler on the mention example to help with the mobile (and desktop) testing experience. * move mention spacer
* Directly paste ClipboardEvents in Safari * Add changeset
* Improve InputEvent data type * Fix insertion of content with newlines on Android * Slice the trailing newline off of pasted text * Add changeset
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix: fix firefox test integration env * chore: test ubuntu apt source * chore: IMMUTABLE_INSTALLS ? * fix: ubuntu version
* fix: undo event when not focused * chore: add changeset * Add `HistoryEditor.withMerging` to docs (#5738) * chore: just trigger test:integration * chore: trigger test:integration * fix: firefox test integration environment (#5742) * fix: fix firefox test integration env * chore: test ubuntu apt source * chore: IMMUTABLE_INSTALLS ? * fix: ubuntu version * fix: undo event when not focused * chore: add changeset * chore: just trigger test:integration * chore: trigger test:integration --------- Co-authored-by: Ty Mick <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* feat * Create gold-cheetahs-rest.md * refactor * fix
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add forthcoming slate-dom package to changeset config * Update .changeset/config.json
* Copied some things from slate-react into new react-dom package * Refactor slate-react to use slate-dom * Fixed failing tests * Created changeset * Ran fix:prettier * Fixed name * Removed duplicate code * Fixed import * Restored linting rule * Bumped slate-dom version * Bumped slate dependency version * Added export of IS_NODE_MAP_DIRTY after rebase
* docs: add context to useComposing hook * fix: run prettier
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Use extended `Editor` type in `useSlateWithV` return type So it matches the return types of `useSlate` and `useSlateStatic`. The `useSlateWithV` return object's `editor` property is currently typed as just a `ReactEditor`, which causes type errors in our app when we try to use it as the extended `Editor` type. * Fix return types in "Editor hooks" docs
…5768) * fix: fix data loss in base `normalizeData` if no blocks allowed Use `unwrapNodes` instead of `removeNodes` to convert block to inline/text nodes. * changeset
…5765) Clarify in the documentation that the default value for `edge` in `Editor.point` is `start`. This is helpful for developers who are not deeply familiar with the framework but need to quickly use it for development. They no longer need to inspect the source code or experiment with sample code to understand the default behavior.
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…tify import xx from "slate-dom" (#5784)
…area>` elements (#5795) * Ignore `selectionchange` events originating from `<input>` and `<textarea>` elements * Linter fixes
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…omSelection #5741) (#5792) * fix: supplement of (fix: Prevent ReactEditor.toDOMRange crash in setDomSelection #5741) * Update packages/slate-dom/src/plugin/with-dom.ts * Update packages/slate-dom/src/plugin/with-dom.ts * Create gold-tomatoes-grab.md * Update packages/slate-dom/src/plugin/with-dom.ts * Update packages/slate-dom/src/plugin/with-dom.ts --------- Co-authored-by: Dylan Schiemann <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
I noticed that the current example for toggling a code block using the backtick (`) key doesn't work as expected. The issue occurs because `Editor.nodes()` can return text nodes instead of block elements, causing`Transforms.setNodes()` to fail. To fix this, I added an extra check using `Element.isElement(n)`, ensuring that only block elements are transformed.
* fix: types for richtext.tsx * fix: types for check-lists, code-highlighting and custom placeholder * fix: types for editable-voids, embeds, forced-layout, hovering-toolbar * fix: types for remaining examples * fix: typescript error for files in image element * fix: types for examples and some minor fixes * fix: normalize-tokens.ts type * fix: types for [example].tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )