[pull] main from ianstormtaylor:main #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scriminators (#5982) * add `isEditorNode`, `isElementNode`, and `isTextNode` and switch to using them whenever possible. also switch to `node === editor` checks where it makes sense also add a comment to a confusing failure state of `Node.parent` also remove a superfluous call to `Editor.nodes` in certain codepaths of `Editor.wrapNodes` * fix deep checking for `isEditor` and check for new properties from #5307 * convert all instances of `Element.isAncestor` and a few I missed before * changeset * fix pretter complaint in changeset * use new guards in other packages and examples * revert wrap nodes change (keeping new guards) * add other packages to changeset * preemptively update peerDependencies * renamed isXNode functions to Node.isX * replaced a few places where isText is passed as a value directly * removed unneeded imports * update yarn lock so tests can pass * added `Node.isAncestor` sugar function * update jsx examples
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )