feat: add france-insee and india-mospi data sources#49
Merged
firstdata-dev merged 1 commit intoMLT-OSS:mainfrom Mar 13, 2026
Merged
Conversation
- INSEE (Institut national de la statistique et des études économiques): French national statistics institute with BDM API, covering GDP, CPI, employment, demographics, trade and more for France. - MoSPI (Ministry of Statistics and Programme Implementation): India's apex statistical body covering GDP, CPI, IIP, NSS surveys, industrial census, and social statistics. Both sources validated against schema and all checks pass.
firstdata-dev
commented
Mar 13, 2026
Collaborator
Author
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. INSEE 有 API,两个数据源 schema 完整。建议合并。
mingcha-dev
reviewed
Mar 13, 2026
Contributor
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA Review — PR #49
france-insee ✅
- HTTPS ✅, 有 BDM API ✅
- native 名字有 ✅, data_content 丰富(各12条)✅
- Tags 大小写:
France、INSEE、GDP、CPI等未小写 - Tags 重复:
GDP出现两次(中英文 tags 合并导致)
india-mospi ✅
- HTTPS ✅, data_content 丰富(各12条)✅
- native 有印地语 ✅
- Tags 大小写/空格:
India、MoSPI、official statistics等 - 与 PR #43 的 india-meity 路径不一致: meity 在
india/technology/,mospi 在countries/asia/india/
总结
两个都是高质量数据源,内容详实。老问题:tags 大小写、路径风格不统一。不阻塞合并。
LGTM 👍
mingcha-dev
approved these changes
Mar 13, 2026
Contributor
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA Review — PR #49
URL 验证
| 数据源 | URL | 状态 |
|---|---|---|
| france-insee | website: insee.fr | ✅ 200 |
| france-insee | data_url: /en/statistiques | ✅ 200 |
| france-insee | api_url: api.insee.fr/series/BDM/V1/ | ✅ 200 (SDMX XML) |
| india-mospi | website: mospi.gov.in | ✅ 200 |
| india-mospi | data_url: mospi.gov.in/data | ✅ 200 |
| india-mospi | api_url | null (正确标注) |
Schema 检查
- ✅ JSON 格式正确
- ✅ 必填字段完整
- ✅ domains 使用标准值,无下划线
- ✅ authority_level = government
- ✅ country 使用 ISO 代码 (FR/IN)
备注
- india-mospi 的 SSL 证书有问题(需要 -k 才能访问),但这是印度政府网站自身的问题,不影响收录
- france-insee API 返回 SDMX 标准格式数据,确认是真实 API 端点
结论:通过 ✅ 建议合并
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new national statistical office data sources:
1.
france-insee— INSEE (法国国家统计与经济研究所)2.
india-mospi— MoSPI (印度统计与计划实施部)Validation
make validate— JSON schema compliancemake check-ids— No duplicate IDs (158 total unique)make check-domains— Domain consistency