Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Line Height and Color Regressions #271

Merged
merged 5 commits into from
Oct 22, 2020
Merged

Fix Line Height and Color Regressions #271

merged 5 commits into from
Oct 22, 2020

Conversation

spaceninja
Copy link
Member

@spaceninja spaceninja commented Oct 21, 2020 •
edited
Loading

Overview

This PR fixes a small set of regressions from the recent dark mode css
refactor that resulted in increased line height and a lighter color for
post comments and descriptions.

Testing

These changes don't show up in screenshots very well. Instead, try comparing the preview deploy version of the following pages to their production versions:

Be sure to review in both light and dark mode!

@spaceninja
Fix Line Height and Color Regressions
99ce7bd 
This PR fixes a small set of regressions from the recent dark mode css
refactor that resulted in increased line height and a lighter color for
post comments and descriptions.

Fixes #260
@spaceninja
trigger deploy
4ec7192
@jessamynwest
Copy link
Contributor

  1. I don't have dark mode so I am not checking in that. I am sure it's fine.
  2. I am not sure if this is helpful but... comments on both preview AND production permalinking seem fine (generally right size, line height is fine) whereas comments on both preview AND production line height examples seem too small/light. I'm pretty sure this is not what I am supposed to be seeing, so I am not sure how to resolve/explain that.

I'm sorry to be making such a THING about this but the smaller (or lighter? or both?) font is just over the "this is too small" line for me, whereas it was fine before. I am AOK with any changes that help people use Dark Mode usefully but the smaller font is too small. I am sorry, I know you are working hard on this.

@spaceninja
Copy link
Member Author

spaceninja commented Oct 21, 2020 •
edited
Loading

The font size on the comments on list view is small, yes, but it's the same size it was before (none of the font sizes changed, just line height and in the case of the text description, the color).

As for the lightness, I'm not sure what you're seeing — the comments are all using the same color they had before the refactor — #333333 (well, technically rgba(0,0,0,0.8), but those are effectively identical on a white background).

@spaceninja
Copy link
Member Author

FWIW we have a long-standing issue (#243) from @bradchoate about the font size of the comments.

Why don't I bump the list view comments up from 12px to 14px and see how that feels.

@jessamynwest
Copy link
Contributor

I think this is AOK and ready for prime time. Anything else you need from me?

@spaceninja
Copy link
Member Author

Thanks @jessamynwest!

@spaceninja spaceninja merged commit 22aca9b into main Oct 22, 2020
@spaceninja spaceninja deleted the feature/line-height-and-color branch October 22, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardgedee ardgedee Awaiting requested review from ardgedee

@bradchoate bradchoate Awaiting requested review from bradchoate

@jessamynwest jessamynwest Awaiting requested review from jessamynwest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dark-mode CSS update changes layout
2 participants
@spaceninja @jessamynwest