Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with member not being removed from shake #703

Merged
merged 1 commit into from
May 9, 2023

Conversation

AbrhamSayd
Copy link
Contributor

@AbrhamSayd AbrhamSayd commented May 8, 2023

Hey everyone,

I just wanted to share a quick update on my contribution to the project. After investigating the issue #701 with members not being removed from the shake, I found that the members template was missing the "remove-from-shake-button-link" class in the anchor tag of the remove button. This was preventing managers from being properly removed from the shake.

I recorded a short video showing how managers can now be removed from the shake without any issues:

ezgif-4-a466323ac2

@AbrhamSayd AbrhamSayd marked this pull request as draft May 8, 2023 16:16
@AbrhamSayd AbrhamSayd marked this pull request as ready for review May 8, 2023 16:17
@AbrhamSayd
Copy link
Contributor Author

@spaceninja FYI

@spaceninja
Copy link
Member

Interesting — No objection to the code, if it fixes things, but I'll admit to being mystified as to how the absence of a class prevents the code from work? Is there some JS hooked up to the class somewhere?

@spaceninja
Copy link
Member

Okay, I went and looked, and yes, there is JS attached to this class, which is why the button wasn't doing anything before. Good catch, thanks!

this.$root.delegate('.remove-from-shake-button-link', 'click', $.proxy(this.remove_from_shake, this));

@spaceninja spaceninja merged commit 04abeb9 into MLTSHP:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants