Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can resave MLTSHP images to itself #1

Open
shfitz opened this issue Apr 11, 2017 · 8 comments
Open

Can resave MLTSHP images to itself #1

shfitz opened this issue Apr 11, 2017 · 8 comments
Assignees

Comments

@shfitz
Copy link

shfitz commented Apr 11, 2017

At least with the firefox plugin, it's possible to re-save an already existing image to the SHP. On MLKSHK, this duping wasn't permitted. See http://new.mltshp.com/p/PW and http://new.mltshp.com/p/PY for a dupe example.

@shfitz
Copy link
Author

shfitz commented Apr 12, 2017

Related(?) it's not possible to save from mlkshk.com to mltshp.com.

@iLama
Copy link
Member

iLama commented Apr 14, 2017

I'd need more information but this is probably an issue with the site and not the plugins.

@shfitz
Copy link
Author

shfitz commented Apr 16, 2017

Yeah, I don't see any reference to mlkshk in this. I'll poke around the site and see what I can find.

@ardgedee
Copy link

@shfitz Does this behavior still exist? Is it relevant to modern or legacy Firefox?

@shfitz
Copy link
Author

shfitz commented Dec 14, 2017

@ardgedee It's still the case on Chrome (https://mltshp.com/p/1CVE5 was saved from https://mltshp.com/p/1CVE1) and Firefox (http://mltshp.com/p/1CVE6 was saved from https://mltshp.com/p/1CVE1)

@iLama
Copy link
Member

iLama commented Dec 14, 2017

To be clear, you are stating the issue is that the MLTSHP extension can be used to save images already on MLTSHP to MLTSHP as a new post?

If this is the case, then this isn't really a bug with the extensions as much as it is with the main code base, and it might be better to report the bug on the main MLTSHP repo.

@ardgedee
Copy link

@iLama Hm... I think the point is mostly that an extension should be aware of when it's being used to re-save a mltshp post and do something else instead (eg, prompt the user to click the "Save" button on the post instead).

I'm OK with leaving this ticket open to address that as a feature enhancement, but I agree it's not really a bug.

@iLama
Copy link
Member

iLama commented Dec 14, 2017

@ardgedee fair enough, I'll assign it to myself and work on getting the changes into the extensions.

@iLama iLama self-assigned this Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants