Skip to content

Warnings on unused and undefined variables #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

noeensarguet
Copy link
Collaborator

@noeensarguet noeensarguet commented Apr 14, 2025

Adds warnings for the two following cases :

  • Variables that are "unused" in the sense that they're not useful either to compute given back ("restituee") variables or used in a verif
  • Variables that are declared as computed but aren't defined (but potentially used)

We could discuss turning the second case into an error (except for given back variables) once the code base is sanitized, it looks very error-prone to me

@noeensarguet
Copy link
Collaborator Author

En l'état actuel du code, lève beaucoup trop de warnings pour que ce soit utile. Après discussion avec les fonctionnel·le·s, on attend au moins la fin de la déclaration de cette année pour modifier la base de code M, il faudrait merger ensuite pour éviter qu'on se retrouve dans une situation similaire

@noeensarguet noeensarguet force-pushed the unused_and_undef_vars branch from 9124362 to 8962a46 Compare April 14, 2025 16:29
@noeensarguet noeensarguet force-pushed the unused_and_undef_vars branch from 8962a46 to cfe2454 Compare April 15, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant