feat(report): add table output structure signals - #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a warning-only quality-report check for visible table-output structure signals in normalized parser blocks.
Why
Table-labeled parser output can be hard to review when structure signals are missing or inconsistent. This check gives reviewers a conservative signal before using normalized output for Markdown export, chunk records, or manual review.
What
Table Output Structure Signalsas a PASS/WARN check in the quality report.data_grid,rows, optionalcells/html, or delimiter-likecontent.text.Tests
.venv/bin/python -m pytest -p no:cacheprovider tests-> 92 passed.venv/bin/python -m ruff check src tests-> passedgit diff --check-> passed.venv/bin/python -m pdf_quality_report.report --help-> passed.venv/bin/python -m pdf_quality_report.report --input examples/mdpi_pdf_elements/page_006/normalized_blocks.json --output /tmp/page_006_table_signals_report.md-> passed.venv/bin/python -m pdf_quality_report.report --input examples/mdpi_pdf_elements/page_012/normalized_blocks.json --output /tmp/page_012_table_signals_report.md-> passedRisks
Low to medium. Reports now include one additional check, so consumers that assume exactly six checks may need to update. The check can move reports to REVIEW when table-output signals are weak, but it does not add hard failures or change CLI exit behavior.
Rollback
Revert this PR to remove the new check, interpretation text, README update, regenerated example report sections, and tests. Existing report checks and CLI behavior return to the previous shape.