Skip to content

CI: simplify clang-format helpers and use ros: docker images for stable builds#31

Open
jlblancoc wants to merge 2 commits into
developfrom
simplify-ci
Open

CI: simplify clang-format helpers and use ros: docker images for stable builds#31
jlblancoc wants to merge 2 commits into
developfrom
simplify-ci

Conversation

@jlblancoc

Copy link
Copy Markdown
Member

Summary

  • Replace complex Python-based clang_git_format scripts with a simple scripts/formatter.sh supporting --check mode
  • Rename scripts/clang-formatter.shscripts/formatter.sh for consistency across repos
  • Simplify check-clang-format.yml to just apt-get install clang-format-14 + bash scripts/formatter.sh --check
  • Add stable humble/jazzy matrix entries using ros:humble / ros:jazzy pre-built Docker images (faster)
  • Remove legacy .github/check_style.sh, python_clang_format_reqs.txt, and scripts/clang_git_format/

🤖 Generated with Claude Code

…le builds

- Replace complex Python-based clang_git_format with a simple scripts/formatter.sh supporting --check
- Standardize formatter to scripts/formatter.sh (renamed from clang-formatter.sh)
- Simplify check-clang-format.yml to just apt-install clang-format-14 and run the script
- Add stable humble/jazzy matrix entries using ros:humble / ros:jazzy pre-built images

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 10, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jlblancoc has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 53 minutes and 40 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 436a1dcb-d78f-4c2b-8649-1a78cd40e21b

📥 Commits

Reviewing files that changed from the base of the PR and between e853bb7 and 17995a9.

📒 Files selected for processing (16)
  • .github/check_style.sh
  • .github/python_clang_format_reqs.txt
  • .github/workflows/build-ros.yml
  • .github/workflows/check-clang-format.yml
  • scripts/clang-formatter.sh
  • scripts/clang_git_format/.gitignore
  • scripts/clang_git_format/LICENSE
  • scripts/clang_git_format/README.md
  • scripts/clang_git_format/clang_git_format/__init__.py
  • scripts/clang_git_format/clang_git_format/clang_format.py
  • scripts/clang_git_format/clang_git_format/config.py
  • scripts/clang_git_format/clang_git_format/custom_exceptions.py
  • scripts/clang_git_format/clang_git_format/repo.py
  • scripts/clang_git_format/clang_git_format/utils.py
  • scripts/clang_git_format/format_code.py
  • scripts/formatter.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch simplify-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…ed dirs

Without grouping, the -o operators apply at top level and -print0 only
attaches to the last alternative, so files outside the intended directories
can be matched.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant