Skip to content

NF: mex version of mocov_line_covered.c - first attempt #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jul 7, 2025
Merged

NF: mex version of mocov_line_covered.c - first attempt #44

merged 26 commits into from
Jul 7, 2025

Conversation

@nno
Copy link
Contributor

@nno nno commented Jun 30, 2025

  • include mocov_line_covered.c
  • update Makefile to include mex compilation - by default for Octave only, not for Matlab

@nno nno requested review from Remi-Gau and jorgepz June 30, 2025 15:45
@nno
Copy link
Contributor Author

nno commented Jun 30, 2025

It currently fails for Octave with

error: mkoctfile: please install the Debian package "octave-dev" to get the mkoctfile command

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Jul 1, 2025

@nno
octave workflow runs

@nno
Copy link
Contributor Author

nno commented Jul 1, 2025

Thanks Rémi for adding octave-dev!

jorgepz
jorgepz approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@jorgepz jorgepz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simply awesome!!

Nikolaas N. Oosterhof and others added 13 commits July 3, 2025 12:37
OPT: simplify line coverage by removing fourth argument, disable file…
04fd176 
…name check by default
CLN: cleanup dealing with filename check and freeing of fn
16ce1ce
OPT: cache octave string pointer
5494fc3
ENH: allow switching caching filename pointer on or off
905610a
Merge branch 'nf/line_covered_mex' of https://github.com/MOxUnit/MOcov …
7796872 
…into nf/line_covered_mex
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
3604c3b 
for more information, see https://pre-commit.ci
FIX: always check filename
1a2b150
Merge branch 'nf/line_covered_mex' of https://github.com/MOxUnit/MOcov …
e0780e5 
…into nf/line_covered_mex
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4d5908e 
for more information, see https://pre-commit.ci
CLN: fix typo
b5bddab
Merge branch 'nf/line_covered_mex' of https://github.com/MOxUnit/MOcov …
ca11198 
…into nf/line_covered_mex
FIX: include argument checks for .m file version of mocov_line_covered
7227e9b
CLN: do not start "||" at beginning of line
c997f6e
@nno
Copy link
Contributor Author

nno commented Jul 4, 2025

  • split tests in three parts.
  • add more tests for illegal inputs.
  • clean up memory allocation in .c version.
  • provide option for filename pointer caching in .c version, which is off by default (#define CACHE_FILENAME_POINTER 0.
  • remove fourth argument in mocov_line_covered, as the common use case is to always use 1.

@nno nno merged commit cd81d7e into master Jul 7, 2025
14 checks passed
@nno nno deleted the nf/line_covered_mex branch July 7, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorgepz jorgepz jorgepz approved these changes

@Remi-Gau Remi-Gau Awaiting requested review from Remi-Gau

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nno @Remi-Gau @jorgepz