Fix memory leak from cellLimitField in mpas_block_creator_build_cell_halos #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…halos The cellLimitField field is allocated in the mpas_block_creator_build_cell_halos routine and is only used in a call therein to mpas_dmpar_get_exch_list. If not deallocated at the end of the mpas_block_creator_build_cell_halos routine, the memory allocated to cellLimitField would be otherwise be leaked, since there is nothing outisde of the mpas_block_creator_build_cell_halos routine that retains a reference to it and deallocates it. This commit fixes this memory leak by deallocating cellLimitField before the mpas_block_creator_build_cell_halos routine returns.
mgduda
force-pushed
the
framework/fix_cellLimitField_leak
branch
from
2384910 to
90f7ecc
Compare
abishekg7
approved these changes
Jan 23, 2025
mgduda
added a commit
that referenced
this pull request
Feb 4, 2025
This merge fixes a memory leak in mpas_block_creator_build_cell_halos by deallocating the cellLimitField field before the routine returns. The cellLimitField field is allocated in the mpas_block_creator_build_cell_halos routine and is only used in a call therein to mpas_dmpar_get_exch_list. If not deallocated at the end of the mpas_block_creator_build_cell_halos routine, the memory allocated to cellLimitField would be otherwise be leaked, since there is nothing outisde of the mpas_block_creator_build_cell_halos routine that retains a reference to it and deallocates it. * framework/fix_cellLimitField_leak: Fix memory leak from cellLimitField in mpas_block_creator_build_cell_halos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak in
mpas_block_creator_build_cell_halosby deallocating thecellLimitFieldfield before the routine returns.The
cellLimitFieldfield is allocated in thempas_block_creator_build_cell_halosroutine and is only used in a call therein tompas_dmpar_get_exch_list. If not deallocated at the end of thempas_block_creator_build_cell_halosroutine, the memory allocated tocellLimitFieldwould be otherwise be leaked, since there is nothing outisde of thempas_block_creator_build_cell_halos routinethat retains a reference to it and deallocates it.