Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial OpenACC port of atm_rk_dynamics_substep_finish #1267

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Initial OpenACC port of atm_rk_dynamics_substep_finish #1267

wants to merge 5 commits into from

Conversation

abishekg7
Copy link
Collaborator

Initial OpenACC port of atm_rk_dynamics_substep_finish.

@abishekg7 abishekg7 force-pushed the atmosphere/port_atm_rk_dynamics_substep_finish branch from c3aee17 to 580f5e4 Compare January 17, 2025 01:00
@mgduda mgduda added Atmosphere OpenACC Work related to OpenACC acceleration of code labels Jan 17, 2025
@mgduda mgduda requested review from mgduda and gdicker1 January 17, 2025 01:10
gdicker1
gdicker1 suggested changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@gdicker1 gdicker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just a couple of small changes. Then I assume you'd squash into one or two commits?

src/core_atmosphere/dynamics/mpas_atm_time_integration.F Outdated
end if


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this extra blank line that slipped in?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@abishekg7
Copy link
Collaborator Author

This looks good, just a couple of small changes. Then I assume you'd squash into one or two commits?

Thanks and yes, I'll wait for Michael's review before I rebase/squash.

gdicker1
gdicker1 approved these changes Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@gdicker1 gdicker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good now! I'll take another peek when the commits are updated.

mgduda
mgduda requested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@mgduda mgduda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment about adding default(present) clauses, but otherwise the changes look good.

@abishekg7 abishekg7 force-pushed the atmosphere/port_atm_rk_dynamics_substep_finish branch from 2aab36e to 852fa34 Compare January 31, 2025 20:45
@mgduda mgduda self-requested a review January 31, 2025 20:47
@abishekg7
Copy link
Collaborator Author

Updated the parallel regions with default(present) clauses, and results are still bit identical against the latest develop branch (GPU run).

@mgduda : Not fully clear on how to squash these commits. Could use your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdicker1 gdicker1 gdicker1 approved these changes

@mgduda mgduda Awaiting requested review from mgduda

Assignees
No one assigned
Labels
Atmosphere OpenACC Work related to OpenACC acceleration of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abishekg7 @mgduda @gdicker1