Initial OpenACC port of atm_bdy_adjust_dynamics_relaxzone_tend #1269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdicker1
suggested changes
Jan 21, 2025
jim-p-w
reviewed
Jan 21, 2025
abishekg7
force-pushed
the
atmosphere/port_atm_bdy_adjust_dynamics_relaxzone_tend
branch
from
2e993c5 to
5c7d198
Compare
jim-p-w
approved these changes
Feb 3, 2025
|
This looks good to me now. Just waiting for any changes from Michael's review and the final commit(s) |
mgduda
approved these changes
Apr 25, 2025
There was a problem hiding this comment.
Looks good to me.
@abishekg7 I'll merge this after you've reworked the commit history.
This commit enables the GPU execution of atm_bdy_adjust_dynamics_relaxzone_tend using OpenACC directives. Any scalar pointers used within the acc parallel regions are first dereferenced so that they are correctly copied onto the device. Timing information for the temporary OpenACC data transfers in this routine is logged using the timer: atm_bdy_adjust_dynamics_relaxzone_tend [ACC_data_xfer]. Time-invariant fields, meshScalingRegionalCell and meshScalingRegionalEdge, are copied onto the device in mpas_atm_dynamics_init and deleted from the device in mpas_atm_dynamics_finalize.
abishekg7
force-pushed
the
atmosphere/port_atm_bdy_adjust_dynamics_relaxzone_tend
branch
from
af2b0a0 to
f7adde0
Compare
Thanks! I've rebased and cleaned up the commit history. And results are still bit identical with develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the GPU execution of
atm_bdy_adjust_dynamics_relaxzone_tendusing OpenACC directives. Any scalar pointers used within the acc parallel regions are first dereferenced so that they are correctly copied onto thedevice.
Timing information for the temporary OpenACC data transfers in this routine is logged using the timer:
atm_bdy_adjust_dynamics_relaxzone_tend [ACC_data_xfer].Data movements for time-invariant fields are performed in
mpas_atm_dynamics_initandmpas_atm_dynamics_finalize