Fixes for bfb restart and partitions tests in E3SM #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amametjanov
reviewed
Feb 5, 2019
Contributor
There was a problem hiding this comment.
This barrier is not necessary, because there is an implied synchronization among threads at the end of the loop. When needed, such barriers can be removed with
!$omp end do nowait
and threads do not wait after exiting the loop.
Contributor
Author
There was a problem hiding this comment.
Thanks for watching this repo, @amametjanov! That is really helpful to know. I added that thread barrier because I thought it was needed, not because I saw a difference in a test.
Contributor
mark-petersen
force-pushed
the
ocean/kinetic_energy_bfb_restart
branch
from
e146d63 to
495f34c
Compare
Contributor
Author
|
@jonbob These are the fixes for E3SM-Project/E3SM#2702. Please approve when you are ready, and I will merge in. |
jonbob
approved these changes
Feb 6, 2019
Contributor
jonbob
left a comment
jonbob
left a comment
There was a problem hiding this comment.
That's exactly what I had been testing
Contributor
Author
|
Passes bfb match with ocean/develop using gnu with nightly regression suite. That includes restart and partition test in MPAS-O standalone. |
mark-petersen
changed the title
mark-petersen
force-pushed
the
ocean/kinetic_energy_bfb_restart
branch
3 times, most recently
from
980f213 to
280e328
Compare
mark-petersen
force-pushed
the
ocean/kinetic_energy_bfb_restart
branch
from
280e328 to
2eab9a1
Compare
willmayfield
pushed a commit
to dtcenter/MPAS-Model
that referenced
this pull request
Jul 22, 2025
…Dev#147) * Scale LAI data by 10 at static generation * Remove LAI scaling by 10 * Add comment for LAI scaling * Update version number * Use scale factor from input data file
ywangwof
added a commit
to NOAA-National-Severe-Storms-Laboratory/frdd-MPAS-Model
that referenced
this pull request
Jul 30, 2025
dustinswales
pushed a commit
to dustinswales/MPAS-Model
that referenced
this pull request
Jul 31, 2025
… and fixed issues detected with the GNU compiler (MPAS-Dev#123) * Fixed NSSL 2-moment MP interface, added horizontal eddy diffusion and fixed issues detected with GNU compiler * Updated .gitmodules for NSSL_GNU_2.9 * Reduced uh_smooth parameter to 0.1 * Added back removed spaces and ignored changes with submodules TEMPO & MYNN-EDMF temporarily * Added runtime parameters mono_filter4 & vert_adv_5th for using monotonic fluxes for 4th filter (true) and using 5th order scheme for vertical transport of scalars (false) * Fixed for backward compatibility * Made sure the default settings for 2d eddy mixxing run identically as before * Removed not used namelist variables * Removed extra file src/core_atmosphere/physics/physics_wrf/module_cu_gf_mpas.F * Updated version number to 8.3.0-1.9 * Removed extra spaces and empty lines * One more change to keep format consistent with the original NCAR version * Merge missing files from MPAS-Dev#147 in last merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three changes.
When running E3SM with melt fluxes on, the first is needed for bfb restarts (E3SM-Project/E3SM#2702) and all three for bfb partition tests (E3SM-Project/E3SM#2739).