Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added modified option for column physics #478

Open
wants to merge 1 commit into
base: seaice/develop
Choose a base branch
from

Conversation

akturner
Copy link
Collaborator

The title above should be a 1 line short summary of the pull request (i.e. what the project the PR represents is intended to do).

Enter a description of this PR. This should include why this PR was created, and what it does.

Testing and relations to other Pull Requests should be added as subsequent comments.

See the below examples for more information.
MPAS-Dev/MPAS#930
MPAS-Dev/MPAS#931

@akturner akturner self-assigned this Mar 18, 2020
Copy link
Contributor

@njeffery njeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested all four testsuites (standard, standard_bgc, snow_tracer_physics and aerosol_shortwave) with the config_column_options = "original" and "modified". Regression tests were compared with seaice/develop. All tests passed. I also compared the restart files for each test with the original option with the result from the modified runs. Results were BFB with the corresponding tests.

Copy link

@proteanplanet proteanplanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This runs and passes an ERS test in E3SM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants