-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make timekeeping module private by default #573
base: develop
Are you sure you want to change the base?
Make timekeeping module private by default #573
Conversation
Made timekeeping module private with explicit public statements for public members Fixed bug in mpas_forcing which used mpas_timekeeping rather than mpas_derived_types in interfaces
@akturner , this looks like helpful cleanup. I have a few questions about certain member of mpas_timekeeping being public (which I guess points to the need for this sort of cleanup).
Apart from understanding those issues (and maybe @mgduda knows the answers), I'm good with this PR. |
@akturner Having taken a quick scan through the changes, this all looks good. I'll do more thorough testing with a broader range of compilers soon. I did find that we will need to fix a few module |
@matthewhoffman The Regarding the use of |
It seems like |
I'm certainly not opposed to |
As of PR #582, we've addressed issues in the atmosphere core that would lead to build errors after the merge of this PR. I like the idea of adding an |
@akturner , it looks like this PR has fallen through the cracks. Is this something that we should still try to merge? Or should it be closed? |
Made timekeeping module private with explicit public statements for public members
Fixed bug in mpas_forcing which used mpas_timekeeping rather than mpas_derived_types in interfaces