Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vertexDegree back into variational velocity solver. #768

Open
wants to merge 1 commit into
base: seaice/develop
Choose a base branch
from

Conversation

akturner
Copy link
Collaborator

A previous performance PR changed vertexDegree in the variational velocity solver for the hardwired value of "3". This prevents the code from working correctly for quadrilateral meshes, that are used in idealized test cases and comparisons with structured models such as CICE.

@akturner
Copy link
Collaborator Author

@amametjanov: Hi Az, the previous performance PR changed "vertexDegree" for "3" in the variational velocity solver. This prevents the code from working for quadrilateral (vertexDegree=4) meshes that are used for test cases and for comparisons with structured sea ice models. Hopefully this doesn't affect performance too much.

Copy link
Contributor

@amametjanov amametjanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was trying to help a compiler optimize the inner loop (with the constant number of iterations of the middle loop). I didn't see vertexDegree other than 3 in mesh specification document and was too optimistic. Thanks for the fix.

@akturner
Copy link
Collaborator Author

@amametjanov : Thanks! Yeah, its not used in E3SM and the ocean people who wrote the spec. don't use it either, so no reason for you to know. I should have seen this when I reviewed the PR.
Cheers Ade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants