Added vertexDegree back into variational velocity solver. #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amametjanov: Hi Az, the previous performance PR changed "vertexDegree" for "3" in the variational velocity solver. This prevents the code from working for quadrilateral (vertexDegree=4) meshes that are used for test cases and for comparisons with structured sea ice models. Hopefully this doesn't affect performance too much. |
amametjanov
approved these changes
Dec 11, 2020
|
@amametjanov : Thanks! Yeah, its not used in E3SM and the ocean people who wrote the spec. don't use it either, so no reason for you to know. I should have seen this when I reviewed the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous performance PR changed vertexDegree in the variational velocity solver for the hardwired value of "3". This prevents the code from working correctly for quadrilateral meshes, that are used in idealized test cases and comparisons with structured models such as CICE.