Fix subtle problems in hydro timestepper #835
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge cleans up some obscure issues in the hydrology model's adaptive timestepper. It ignores edges on the grounding line in the diffusive CFL check, because the diffusive flux is not actually applied on those edges and they can otherwise be overly restrictive. It also makes the model die if the hydrology dt becomes less than 1 second. This should avoid the model hanging when unstable cavity growth occurs.