Fix subtle problems in hydro timestepper #835
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhoffman
force-pushed
the
landice/hydro_timestepper_fixes
branch
from
c1928ff to
2d50b5f
Compare
It had been showing the dt from the previous subcycle instead of the final one. Now it displays both.
The diffusive flux is not actually applied at edges on the GL, so the diff CFL condition there may be overly restrictive.
For calculations of hydropotential gradient in the channel model, this commit swtiches from using the full hydropotential to hydropotentialBase (which ignores the hydropotential contribution from the thickness of the water). This seems to prevent channel blowups around lakes. It also might not be modeling channel interactiosn with lakes properly. This requires further investigation.
matthewhoffman
force-pushed
the
landice/hydro_timestepper_fixes
branch
from
2d50b5f to
093f44c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge cleans up some obscure issues in the hydrology model's adaptive timestepper. It ignores edges on the grounding line in the diffusive CFL check, because the diffusive flux is not actually applied on those edges and they can otherwise be overly restrictive. It also makes the model die if the hydrology dt becomes less than 1 second. This should avoid the model hanging when unstable cavity growth occurs.