Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subtle problems in hydro timestepper #835

Open
wants to merge 6 commits into
base: landice/develop
Choose a base branch
from

Conversation

matthewhoffman
Copy link
Member

This merge cleans up some obscure issues in the hydrology model's adaptive timestepper. It ignores edges on the grounding line in the diffusive CFL check, because the diffusive flux is not actually applied on those edges and they can otherwise be overly restrictive. It also makes the model die if the hydrology dt becomes less than 1 second. This should avoid the model hanging when unstable cavity growth occurs.

It had been showing the dt from the previous subcycle instead of the final one.
Now it displays both.
The diffusive flux is not actually applied at edges on the GL, so the diff CFL
condition there may be overly restrictive.
For calculations of hydropotential gradient in the channel model, this
commit swtiches from using the full hydropotential to hydropotentialBase
(which ignores the hydropotential contribution from the thickness of the
water).

This seems to prevent channel blowups around lakes.  It also might not
be modeling channel interactiosn with lakes properly.  This requires
further investigation.
@matthewhoffman matthewhoffman force-pushed the landice/hydro_timestepper_fixes branch from 2d50b5f to 093f44c Compare April 16, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant