-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for Cray OpenMP offloading on AMD GPUs #971
Open
jychang48
wants to merge
73
commits into
MPAS-Dev:atmosphere/develop-openacc
Choose a base branch
from
jychang48:atmosphere/develop-openacc
base: atmosphere/develop-openacc
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Initial support for Cray OpenMP offloading on AMD GPUs #971
jychang48
wants to merge
73
commits into
MPAS-Dev:atmosphere/develop-openacc
from
jychang48:atmosphere/develop-openacc
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elopment purposes
…pas_atm_time_integration.F
…mics/mpas_atm_time_integration
…_wrf/module_bl_XXX.F
…/module_cu_ntiedtke.F
…/module_sf_sfclay.F
…ys_XXX.F At this point, all of these ACC directives are ported to OpenMP offloading: !$acc declare create(...) !$acc data create(...) !$acc data copyin(...) !$acc enter data create(...) !$acc enter data copyin(...)
…m_compute_dyn_tend
…ical discrepancy observed here
…ep_pert_variables_work
atm_divergence_damping_3d atm_compute_dyn_tend_work atm_compute_dyn_tend_work_rk23
atm_advance_acoustic_step_work physics_get_tend
…tnpass Atmosphere/develop openacc amd ftnpass
Note, many of the changes in this PR dealt with manually incorporating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only supported through the cray ftn compiler.
All OMP directives added on top of existing ACC directives.
Only core dynamics ported. Physics not touched.
Macro definitions (MPAS_AMD_OFFLOAD, GPUOMP, etc) are temporary measures and will be renamed or removed when the AOMP compiler is supported. Should also eventually work with Intel and NVIDIA GPUs.