Warning removal #274
Merged
Warning removal #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertodr
reviewed
Jan 6, 2026
robertodr
approved these changes
Jan 6, 2026
Contributor
robertodr
left a comment
robertodr
left a comment
There was a problem hiding this comment.
Thanks Niklas. Please have a look at my comment, we can merge once you've addressed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with clang21, a lot of new warnings popped up.
Removed all warnings (at least with clang21 + macOS 26 on M4 Mac)
Also includes a fix that allows compiling of MRChem + MRCPP on Mac again, as one definition of the multiply function was missing for macOS on ARM.