Skip to content

Conversation

@J-Meyers
Copy link
Contributor

@J-Meyers J-Meyers commented Dec 6, 2024

Changed apps/libraries

  • Renamed flag to bounding box from None to NoFlags to prevent autogenerated stubs from conflicting with python None type

PR Description

  • Fixes python typing issue where previously it tried to annotate another type to the None type in the autogenerated stub
    • This issues is particularly visible if trying to use mypy which generates an unrecoverable error (line number difference is because this was done using an older commit of mrpt)
    • The current issue effectively prevents using mypy for type checking in any projects which have any sort of transitive import of mrpt
      image

I acknowledge to have:

(Notify: @MRPT/owners )

@jlblancoc jlblancoc merged commit d3bc524 into MRPT:develop Dec 8, 2024
6 checks passed
@jlblancoc
Copy link
Member

Good point! It would be great to scan the rest of the Python wrapping code for other similar cases...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants