Skip to content

MSVC doesn't allow dependent names in template parameters #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2025
Merged

MSVC doesn't allow dependent names in template parameters #1341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/mrpt_math/include/mrpt/math/TOrientedBox.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ class TOrientedBox_
/** The number of planes defined by a box */
constexpr static std::size_t PLANES_PER_BOX = 6;

using plane_array_t = std::array<mrpt::math::TPlane, PLANES_PER_BOX>;

TOrientedBox_() = default;

/** Constructor pose of the center and dimensions in local coordinates */
Expand Down Expand Up @@ -115,7 +117,7 @@ class TOrientedBox_
* The ordering of the planes is: [0]=front, [1]=left, [2]=right, [3]=top, [4]=back, [5]=bottom.
* Plane normals are all pointing outwards
*/
[[nodiscard]] std::array<mrpt::math::TPlane, PLANES_PER_BOX> getBoxPlanes() const;
[[nodiscard]] plane_array_t getBoxPlanes() const;

[[nodiscard]] bool operator==(const TOrientedBox_<T>& o) const
{
Expand Down
2 changes: 1 addition & 1 deletion modules/mrpt_math/src/TOrientedBox.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ TBoundingBox_<T> mrpt::math::TOrientedBox_<T>::getAxisAlignedBox() const
}

template <typename T>
std::array<mrpt::math::TPlane, mrpt::math::TOrientedBox_<T>::PLANES_PER_BOX>
typename mrpt::math::TOrientedBox_<T>::plane_array_t
mrpt::math::TOrientedBox_<T>::getBoxPlanes() const
{
using mrpt::math::TPlane;
Expand Down
Loading