Fix Tool Executor and Parser for Chat Persistence#100
Conversation
- Explicitly return `HelpTool` from `LLMParser` instead of relying on string parsing - Fix unawaited db.add call in tool_executor.py - Fix unawaited db.add in messaging_service.py - Update tests to accommodate explicit HelpTool instances and updated retry/fallback logic Co-authored-by: MRiabov <108194191+MRiabov@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR fixes issues identified while implementing the 019-business-workflow-defaults spec, specifically around the
LLMParserretry and fallback mechanism, and some synchronous calls in async execution paths.Changes:
Nonewith returning a populatedHelpToolobject inLLMParserwhen tool parsing fails completely. This ensures the caller receives a valid tool format.db.addcall intool_executor.py(customer_repo.add()) that was causingTypeError: object NoneType can't be used in 'await' expressionbecauseself.customer_repo.addwas defined synchronously. Note:customer_repo.addis now called synchronously intool_executor.awaitfrom a synchronousdb.add()call inmessaging_service.pyto fix another related warning.PR created automatically by Jules for task 12547465135851460276 started by @MRiabov