fix(assignment): Ensure reassigned jobs emit JOB_UNASSIGNED and clear gcal_event_id#101
fix(assignment): Ensure reassigned jobs emit JOB_UNASSIGNED and clear gcal_event_id#101MRiabov wants to merge 1 commit into
Conversation
… gcal_event_id When a job is reassigned, the `AssignmentService` now explicitly checks if there is an existing employee and unassigns them, emitting `JOB_UNASSIGNED` and clearing `gcal_event_id` before assigning the new employee and emitting `JOB_ASSIGNED`. This allows the `calendar_sync_handler` to properly delete the previous user's calendar event, preventing dangling jobs on their personal Google Calendar. Added unit tests to assert the correct event emission sequence and `gcal_event_id` clearing. Co-authored-by: MRiabov <108194191+MRiabov@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes an issue identified in the
024-google-calendar-integrationspecification where reassigning jobs viaAssignmentServicefailed to trigger the proper unassignment logic, leaving dangling events on the previous employee's Google Calendar.assign_jobto check for and unassign an existing employee, emittingJOB_UNASSIGNEDwith the correct ID.job.gcal_event_id = Noneand refreshes to ensure calendar sync cleanup occurs cleanly.tests/test_calendar_reassignment_bug.pyto prevent regressions.PR created automatically by Jules for task 8211951920192974365 started by @MRiabov