Fix RBAC denial message format and conditional disclaimer#84
Conversation
- Remove "Error: " prefix from ToolExecutor denial message to match spec (FR-005). - Update IdleHandler to only append RBAC disclaimer for restricted keywords (FR-007). - Add regression tests in tests/test_rbac_bugs.py. - Verified with existing tests in tests/test_rbac_fixes.py. Co-authored-by: MRiabov <108194191+MRiabov@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR addresses two RBAC implementation bugs:
ToolExecutorwas prepending "Error: " to the denial message, violating FR-005 which requires a specific format starting with "It seems you are trying to...".IdleHandlerwas appending the "user does not have role-based access" disclaimer to allHelpToolresponses for non-owners. This has been corrected to only append the disclaimer if the user's query contains restricted keywords (e.g., "invoice", "revenue").Tests were added in
tests/test_rbac_bugs.pyto verify these fixes and ensure regression testing.PR created automatically by Jules for task 9499816231560334188 started by @MRiabov