Fix calendar reassignment sync and invoice lazy loading bugs#86
Conversation
…ignment and fix invoice generation lazy loading error. - Emits JOB_UNASSIGNED and clears gcal_event_id during job reassignment to prevent sync errors. - Explicitly loads job.business in InvoiceService to prevent MissingGreenlet/DetachedInstanceError. - Adds regression tests: tests/test_calendar_reassignment_bug.py and tests/test_invoice_lazy_load_bug.py. Co-authored-by: MRiabov <108194191+MRiabov@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR fixes two bugs:
JOB_UNASSIGNEDand explicitly clearinggcal_event_id.InvoiceService.create_invoiceaccessedjob.businesswithout ensuring it was loaded, leading to async lazy loading errors. This is fixed by checking and explicitly loading the relationship if needed.Regression tests are included for both scenarios.
PR created automatically by Jules for task 8528032049003158851 started by @MRiabov