Skip to content

Fix MockRoutingService bugs: Availability, Travel Time, Distance Calculation#87

Open
MRiabov wants to merge 1 commit into
mainfrom
fix-mock-routing-bugs-5390812382860715750
Open

Fix MockRoutingService bugs: Availability, Travel Time, Distance Calculation#87
MRiabov wants to merge 1 commit into
mainfrom
fix-mock-routing-bugs-5390812382860715750

Conversation

@MRiabov
Copy link
Copy Markdown
Owner

@MRiabov MRiabov commented Feb 16, 2026

Fixed 3 critical bugs in MockRoutingService:

  1. Availability Check: Jobs were scheduled without checking CustomerAvailability windows. Added logic to wait for window start or reject if job doesn't fit.
  2. Travel Time Calculation: Travel time was off by factor of 1000 (0.2 mins for 111km). Fixed unit conversion.
  3. Distance Calculation: Distance was always calculated from employee home, ignoring spatial chaining. Implemented greedy nearest-neighbor logic tracking employee current location.

Verified with new regression tests in tests/test_mock_routing_bugs.py.


PR created automatically by Jules for task 5390812382860715750 started by @MRiabov

…ance)

- Implement iterative nearest-neighbor greedy algorithm for better spatial routing.
- Add `_check_availability` to enforce CustomerAvailability constraints (wait or reject).
- Fix travel time calculation unit (use km instead of meters/1000).
- Fix distance calculation to use employee's current location instead of home.
- Add regression test `tests/test_mock_routing_bugs.py`.

Co-authored-by: MRiabov <108194191+MRiabov@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant