Fix Invoice Tax Calculation and Display#90
Conversation
- Modified `InvoiceService.create_invoice` to calculate subtotal, tax amount, and total value based on business tax settings. - Added explicit eager loading of `job.business` and `job.line_items` in `create_invoice` to prevent `MissingGreenlet` errors and ensure correct async access. - Updated `InvoiceService` to persist these calculated tax values to the `Job` record snapshot. - Updated `PDFGenerator` to include `subtotal`, `tax_amount`, and `tax_rate` in the template context. - Updated `src/templates/invoice.html` to display the tax breakdown (Subtotal, Tax, Total). - Fixed regression tests in `tests/test_invoice_logic.py`, `tests/test_invoice_generation.py`, and `tests/test_payment_link.py` to align with the new logic and mocking requirements. Co-authored-by: MRiabov <108194191+MRiabov@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR fixes a bug where tax settings (default tax rate and inclusive/exclusive mode) were ignored during invoice generation. It implements tax calculation logic within
InvoiceService, persists the calculated values to theJobrecord, and updates the PDF template to display the breakdown. Additionally, it resolvesMissingGreenleterrors inInvoiceServiceby enforcing eager loading of necessary relationships.PR created automatically by Jules for task 11342746705220958570 started by @MRiabov