Fix pipeline transition for NEW_LEAD and session isolation in handlers#92
Fix pipeline transition for NEW_LEAD and session isolation in handlers#92MRiabov wants to merge 1 commit into
Conversation
…ion isolation in quote handler - Update `handle_contact_event` to transition customers from `NEW_LEAD` to `CONTACTED`. - Update `handle_quote_sent` to use `get_session_maker()` for proper database session isolation (especially in tests). - Add regression tests in `tests/test_pipeline_logic.py`. Co-authored-by: MRiabov <108194191+MRiabov@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR fixes a bug where customers in the
NEW_LEADstage would not transition toCONTACTEDupon a contact event. It also fixes an issue inhandle_quote_sentwhereAsyncSessionLocalwas used directly, bypassing the test database context, which could lead to test failures or data pollution. Comprehensive tests were added totests/test_pipeline_logic.pycovering these scenarios with proper async mocking.PR created automatically by Jules for task 8310343979550052136 started by @MRiabov