Add tax calculation and snapshot to invoices#94
Conversation
- Added `subtotal`, `tax_amount`, `tax_rate`, `total_amount` to `Invoice` model in `src/models/__init__.py`. - Updated `InvoiceService.create_invoice` to calculate taxes using `TaxCalculator` and snapshot results to `Invoice` and `Job`. - Updated `PDFGenerator.generate_invoice` to accept and use tax values. - Updated `src/templates/invoice.html` to display tax breakdown. - Added `tests/test_invoice_tax_fix.py` and updated `tests/test_invoice_logic.py`. Co-authored-by: MRiabov <108194191+MRiabov@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR addresses the missing tax calculation and persistence in invoice generation.
Changes:
Invoicemodel.InvoiceServicenow usesTaxCalculatorto compute tax details before generating the PDF and saving the record.PR created automatically by Jules for task 3063032311922309559 started by @MRiabov