Skip to content

Fix MockRoutingService Logic Bugs#95

Open
MRiabov wants to merge 1 commit into
mainfrom
fix-mock-routing-bugs-9597031689121396872
Open

Fix MockRoutingService Logic Bugs#95
MRiabov wants to merge 1 commit into
mainfrom
fix-mock-routing-bugs-9597031689121396872

Conversation

@MRiabov
Copy link
Copy Markdown
Owner

@MRiabov MRiabov commented Feb 24, 2026

Fixed critical bugs in MockRoutingService:

  1. Distance Calculation: Previously, the service calculated distance from the employee's default start location for every job in the sequence. It now correctly updates the employee's location after each assignment, calculating the distance from the previous job to the current job.
  2. Travel Time Calculation: Corrected unit mismatch where km were treated as meters or incorrect formula was used. Now uses _haversine (km) and assumes 30km/h speed.
  3. Availability Windows: Implemented _check_availability to respect CustomerAvailability windows. Jobs are now scheduled within open windows, waiting if early, or skipped if they don't fit.

Added tests/test_mock_routing_regression.py to verify these fixes and prevent regression.


PR created automatically by Jules for task 9597031689121396872 started by @MRiabov

- Fixed distance calculation to use the employee's current location (chain topology) instead of default start location (star topology).
- Fixed travel time calculation to use consistent units (km and km/h).
- Implemented customer availability window checks.
- Added regression tests in `tests/test_mock_routing_regression.py`.

Co-authored-by: MRiabov <108194191+MRiabov@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant