Fix MockRoutingService Logic Bugs#95
Conversation
- Fixed distance calculation to use the employee's current location (chain topology) instead of default start location (star topology). - Fixed travel time calculation to use consistent units (km and km/h). - Implemented customer availability window checks. - Added regression tests in `tests/test_mock_routing_regression.py`. Co-authored-by: MRiabov <108194191+MRiabov@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Fixed critical bugs in
MockRoutingService:_haversine(km) and assumes 30km/h speed._check_availabilityto respectCustomerAvailabilitywindows. Jobs are now scheduled within open windows, waiting if early, or skipped if they don't fit.Added
tests/test_mock_routing_regression.pyto verify these fixes and prevent regression.PR created automatically by Jules for task 9597031689121396872 started by @MRiabov