Fix MockRoutingService logic errors and add regression tests#96
Conversation
…lability windows - Fixed travel time calculation: Now correctly converts kilometers to seconds (dist_km * 2 * 60) for 30km/h speed, instead of dividing by 1000. - Implemented Iterative Nearest Neighbor (Greedy VRP): Now tracks employee location and time updates after each assignment to calculate distance from the *previous* job (Chain Topology) rather than always from the start location. - Added Availability Window Support: Now respects `CustomerAvailability` windows, finding the earliest valid slot and adjusting arrival times or rejecting jobs that don't fit. - Added regression tests in `tests/test_mock_routing_regression.py` covering these three areas. Co-authored-by: MRiabov <108194191+MRiabov@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR fixes critical logic errors in
MockRoutingServiceused for development and testing of the routing feature.Bugs Fixed:
(dist / 1000) * 2. Given_haversinereturns km, this resulted in values ~1000x too small (likely intended for meters but using km). Fixed todist_km * 2(minutes) -> seconds.CustomerAvailability. It now checks availability windows and schedules accordingly, or leaves jobs unassigned if they cannot fit.Testing:
tests/test_mock_routing_regression.pywith 3 specific test cases verifying the fixes.PR created automatically by Jules for task 14751321410343276879 started by @MRiabov