Fix MockRoutingService logic and add regression tests#97
Conversation
- Implement iterative nearest-neighbor strategy in MockRoutingService to correctly update employee location after assignment. - Fix travel time calculation unit error (was calculating seconds instead of minutes * 60). - Add support for CustomerAvailability checks in routing logic. - Add regression tests in `tests/test_mock_routing_regression.py` covering chaining logic, travel time units, and availability windows. Co-authored-by: MRiabov <108194191+MRiabov@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixed critical bugs in
MockRoutingService:CustomerAvailabilitywindows. Jobs are now only assigned if they fit within the customer's specified time windows.Added a new test file
tests/test_mock_routing_regression.pyto verify these fixes and prevent regression. Confirmed that existing tests intests/services/test_routing.pystill pass.PR created automatically by Jules for task 14820617412672648436 started by @MRiabov