Fix Google Calendar Reassignment Sync and Invoice Generation Bug#98
Fix Google Calendar Reassignment Sync and Invoice Generation Bug#98MRiabov wants to merge 1 commit into
Conversation
… Service\n\n* Update AssignmentService to explicitly emit `JOB_UNASSIGNED` with old employee ID on reassignment so that `CalendarSyncHandler` can clean up external calendar events correctly before the new `JOB_ASSIGNED` is dispatched. Includes refreshing the `job` to capture cleared `gcal_event_id`.\n* Fix `MissingGreenlet` / `DetachedInstanceError` in `InvoiceService.create_invoice` by explicitly reloading `job.business`, `job.customer`, and `job.line_items` with `selectinload`.\n* Remove blocking synchronous file I/O operations (`with open(...)`) from `src/services/workflow.py` running in asynchronous loops to improve performance.\n* Included corresponding regression test updates and coverage for calendar unassignment logic and missing greenlet exceptions. Co-authored-by: MRiabov <108194191+MRiabov@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
JOB_UNASSIGNEDfirst.MissingGreenleterror during async document rendering by eagerly fetching related job entities (customer, business, items)./tmp/file-writing blocking calls out ofworkflow.pyfor significant backend performance bump.PR created automatically by Jules for task 1253262858371777726 started by @MRiabov