-
Notifications
You must be signed in to change notification settings - Fork 0
BE-FE/Implements-JWT-Authentication #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…outer package in frontend
backend/src/models/UserModel.js
Outdated
| return function (d, b) { | ||
| extendStatics(d, b); | ||
| function __() { this.constructor = d; } | ||
| d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let's try to avoid single letter variables, is very difficult to understand the code in this way
why do we need to use proto ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is re utilized from react-backend repository which was wrote like this, I can do a deep research to refactor the backend and be more descriptive from a intent perspective
backend/src/utils/generalUtils.js
Outdated
| config = parseDatabaseArguments(process.argv); | ||
| } | ||
| return config; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this file? seems part of some code generator?, is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote this before in the react-backend repository in order to be able to run the localDatabase with arguments passed to the npm script, something like... npm run start:local dbname=localhost dbusername=myDbUser dbpassword=myDbPass
…ser sagas to retrieve all users from service. Starting CRUD
…. Validate token in backend and hits service with token in ApiService
…r to enable verificatoin properly
…- Implements forgotPass request in frontend
…a Domain Driven design perspective
Background
Changes Done
Pending
Persist Login when token
Login Case