Skip to content

Add new command /top #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mrtechtroid
Copy link
Contributor

@mrtechtroid mrtechtroid commented Jun 17, 2024

  • This PR has been tested locally.
  • Based on suggestion Discord have implemented the command /top whose majority code has been taken from \top50.
  • To prevent abuse/server lag, the value taken is limited to between [1,200] which can be updated to higher or lower as required.

@LoneWolfHT
Copy link
Member

I feel like it might be a good idea to fix the ranking backends before merging this

@mrtechtroid
Copy link
Contributor Author

@LoneWolfHT now since backend is fixed? This could be merged?

@LoneWolfHT
Copy link
Member

@LoneWolfHT now since backend is fixed? This could be merged?

It will need to be reworked to fit the new API, and I would eventually like to change it to have a a GUI button like in the match summary, which may or may not be easy to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants