Make listen address configurable and allow unix domain sockets#28
Merged
Conversation
|
wow so rude, this is my job! /j very neat, if there's interest I could look into adding https://codeberg.org/networkException/provided-listeners, otherwise that'll end up as a local patch once I finally get to deploy this |
Contributor
Author
|
Oh that's nice! |
MTRNord
approved these changes
May 22, 2026
MTRNord
left a comment
MTRNord
left a comment
Owner
There was a problem hiding this comment.
LGTM. Just the one nit I am seeing locally could probably be fixed before merging.
Thanks for making the PR!
Contributor
Author
|
Rebased to resolve the conflict and fixed @MTRNord :) |
MTRNord
approved these changes
May 22, 2026
MTRNord
left a comment
MTRNord
left a comment
Owner
There was a problem hiding this comment.
LGTM thanks!
(dont mind the ci fail... Guess my fix didnt fix it :D)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @networkException @MTRNord