Skip to content

Add character & NPC map-images (in GroupManager and on map) - #391

Closed
Sunnyl75 wants to merge 38 commits into
MUME:masterfrom
Sunnyl75:feature/map-tokens-clean
Closed

Add character & NPC map-images (in GroupManager and on map)#391
Sunnyl75 wants to merge 38 commits into
MUME:masterfrom
Sunnyl75:feature/map-tokens-clean

Conversation

@Sunnyl75

Copy link
Copy Markdown
  • Images selected from "Tokens" folder in "Modding" Folder from pop up in GroupManager
  • Selections persist.
  • Toggle on/off for images in groupmanager and on map
  • Resize image in groupmanager with row
  • Player image only shown on map if in same room as others.
    GroupManager
    Multiple players

@codecov

codecov Bot commented Jul 15, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.93%. Comparing base (26d1a9d) to head (cbbe149).
⚠️ Report is 113 commits behind head on master.

Files with missing lines Patch % Lines
src/configuration/configuration.cpp 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
- Coverage   66.48%   65.93%   -0.55%     
==========================================
  Files          85       86       +1     
  Lines        4186     4239      +53     
  Branches      255      259       +4     
==========================================
+ Hits         2783     2795      +12     
- Misses       1403     1444      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sunnyl75
Sunnyl75 force-pushed the feature/map-tokens-clean branch from fb1b1ce to 117aa13 Compare July 18, 2025 23:07
@Sunnyl75
Sunnyl75 force-pushed the feature/map-tokens-clean branch from 1030fb6 to 0c9070b Compare August 11, 2025 00:40
Sunnyl75 and others added 25 commits August 14, 2025 11:11
…hing

- Introduced a new CHARACTER_TOKEN column to the Group Manager table.
- Integrated TokenManager for resolving and loading character token images.
- Implemented fallback logic and QPixmapCache in TokenManager to reduce redundant image loading.
- Added GroupDelegate logic to render icons, with default size set to 32x32 pixels.
- Suppressed repeated debug output now that caching is effective.
- Layout and header adjusted to support the new Icon column without disrupting existing columns.

Foundation laid for future enhancements, including token toggle and dynamic resizing.
* Uploads token PNGs once and registers them in the live OpenGL renderer
* Player token drawn immediately; mounts/NPCs hidden in player???s room
* Prevents duplicate overlays and black fallback
@Sunnyl75
Sunnyl75 force-pushed the feature/map-tokens-clean branch from 7db800c to 44f359c Compare August 14, 2025 01:12
@nschimme
nschimme marked this pull request as draft August 14, 2025 13:49
@nschimme
nschimme force-pushed the master branch 4 times, most recently from da9f53b to 2050361 Compare August 31, 2025 20:29
@Sunnyl75

Copy link
Copy Markdown
Author

Superseded by the new Qt6/checkbox defaults PR.

@Sunnyl75 Sunnyl75 closed this Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants