feat: 为 sidebar-footer 添加折叠功能,fix: 修复搜索图标偏下问题, feat(map): 新增两个电话亭坐标点位#14
Open
Misaka273 wants to merge 2 commits into
Open
feat: 为 sidebar-footer 添加折叠功能,fix: 修复搜索图标偏下问题, feat(map): 新增两个电话亭坐标点位#14Misaka273 wants to merge 2 commits into
Misaka273 wants to merge 2 commits into
Conversation
- 📍 新增电话亭 Maa-NTE#14 (4346.30, 275610.02) - 📍 新增电话亭 #015 (-265642.68, 357669.25)
Reviewer's GuideImplements a collapsible settings section in the sidebar footer with persisted open/closed state, adjusts the sidebar layout to flex to reallocate space when collapsed, fixes the vertical alignment of the search icon, and adds two new phone booth markers to the map data. Sequence diagram for toggling and persisting sidebar footer open statesequenceDiagram
actor User
participant SidebarFooterToggleButton as SidebarFooterToggleButton
participant MapApp as useMapApp
participant LocalStorage
User ->> SidebarFooterToggleButton: click
SidebarFooterToggleButton ->> MapApp: sidebarFooterOpen = !sidebarFooterOpen
MapApp ->> MapApp: watch(sidebarFooterOpen, persistMarkerFilters)
MapApp ->> MapApp: persistMarkerFilters()
MapApp ->> LocalStorage: setItem(markerFilters, updatedFilters)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
.sidebar-footer__toggleis rendered before the footer body while usingflex-direction: column, somargin-top: autowon’t actually push it to the bottom of the footer; consider either rendering the toggle after.sidebar-footer__bodyor using a different flex layout strategy to reliably anchor the toggle at the bottom as described. - The
margin-top: -8pxtweak on.search-iconfeels like a magic number tied to the current font/line-height; you may want to align it using flexbox or vertical-align on the parent container instead so it’s more robust to future UI/style changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `.sidebar-footer__toggle` is rendered before the footer body while using `flex-direction: column`, so `margin-top: auto` won’t actually push it to the bottom of the footer; consider either rendering the toggle after `.sidebar-footer__body` or using a different flex layout strategy to reliably anchor the toggle at the bottom as described.
- The `margin-top: -8px` tweak on `.search-icon` feels like a magic number tied to the current font/line-height; you may want to align it using flexbox or vertical-align on the parent container instead so it’s more robust to future UI/style changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add a collapsible settings section to the sidebar footer, persist its open state, tweak sidebar layout for dynamic space allocation, and align the search icon visually.
New Features:
Bug Fixes:
Enhancements: