Skip to content

Conversation

nickprock
Copy link
Contributor

@nickprock nickprock commented Mar 20, 2025

What does this PR do?

This PR add FastEmbed backend.

related to issue #2313

Before submitting

  • This PR fixes a typo or improves the docs (if yes, ignore all other checks!).
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes (if applicable)?
  • Did you write any new necessary tests?

@MaartenGr
Copy link
Owner

This looks great! Thank you for the PR.

One thing that is missing is some documentation here to showcase how you can use those embeddings.

Also, note that we want to automatically select the embedding model as shown here rather than importing this backend. That removes another layer of complexity for the user.

@nickprock
Copy link
Contributor Author

@MaartenGr thank you, I will do it as soon as possible

@MaartenGr
Copy link
Owner

Awesome, everything looks great. Thank you for taking the time to add this, it is greatly appreciated!

@MaartenGr MaartenGr merged commit faf13eb into MaartenGr:master Mar 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants