Skip to content

Conversation

saikumaru
Copy link
Contributor

What does this PR do?

This PR essentially passes the precomputed embeddings to extract_topics method of KeyBERTInspired to avoid re computing embeddings of documents.

Fixes # #2367

Before submitting

  • This PR fixes a typo or improves the docs (if yes, ignore all other checks!).
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes (if applicable)?
  • Did you write any new necessary tests?

Copy link
Owner

@MaartenGr MaartenGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I left a few small comments but otherwise it is looking good.

@MaartenGr
Copy link
Owner

Awesome, thank you for your work on this! It's great to have this feature in BERTopic.

@MaartenGr MaartenGr merged commit 13c8ed7 into MaartenGr:master Jun 6, 2025
6 checks passed
@saikumaru
Copy link
Contributor Author

Happy to contribute. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants