Hard dependency to prevent conflicts #2396
Merged
+8
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright, this was more annoying than I'd expected.
It turns out that
llvmlite
gives major issues withuv
's dependency manager (see #2311).I initially thought that adding the following would work:
Which it did during local tests. However, it seemed that this was not the case after pushing the package to pypi.org. I hoped it would be fixed with changing the order of the dependencies, which worked locally but again not after I had pushed the package to pypi.org.
So now I'm just going to resort to something that will definitely work, namely putting
llvmlite>0.36.0
as a hard dependency. It already is when you installnumba
throughumap-learn
andhdbscan
, but now we make it a bit more explicit.I will delete the other releases that I hoped would fix the issues with
uv
, namely thev0.17.2
andv0.17.2.post1
releases.