Skip to content

Conversation

makramab
Copy link
Contributor

What does this PR do?

Fixes #2403

Before submitting

  • This PR fixes a typo or improves the docs (if yes, ignore all other checks!).
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes (if applicable)?
  • Did you write any new necessary tests?

@MaartenGr
Copy link
Owner

Thank you for the PR!

At the moment, I'm very hesistant to add another parameter to the BERTopic class. I'd like to keep it all as small as possible with modularity as an important driver. As such, I would prefer to prevent model-specific parameters. Instead, I would suggest setting the init in visualize_topics to "random" as that should be the only (one of the few?) place(s) where it is used.

@makramab
Copy link
Contributor Author

makramab commented Sep 1, 2025

Thanks for the feedback! That makes sense. I’ll go ahead and change the visualize_topics function to set init="random" instead of adding a parameter.

@makramab
Copy link
Contributor Author

makramab commented Sep 1, 2025

Just pushed the changes, @MaartenGr. thanks again for the review!

@MaartenGr
Copy link
Owner

Wow, look at me waiting 3 weeks before answering... Sorry! Thank you for the changes and your patience. Looks good to me and can be merged.

@MaartenGr MaartenGr merged commit 3658e32 into MaartenGr:master Sep 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visualize_topics randomness

2 participants