Fix delete_topics crash when custom labels are set - #2534
Open
gyanu2507 wants to merge 3 commits into
Open
Conversation
custom_labels_ is a list aligned with sorted topic ids, so treating it as a dict raised AttributeError on delete.
Deleting topic 0 still leaves a topic 0 because remaining topics are renumbered by frequency.
kmeans remaps remaining clusters, so deleting one topic can leave the unique count unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this after
set_topic_labels—delete_topics()blows up withAttributeError: 'list' object has no attribute 'items'.custom_labels_is a list in topic-id order (that's whatset_topic_labelsstores). The delete path treated it as a dict. It also triedcustom_labels_[-1] = ""when creating the outlier topic, which overwrites the last label instead of adding one for-1.This remaps the surviving labels and writes them back as a list, including an empty label if
-1shows up for the first time.Fixes #2529