Fixes issue #1104 (Rendering pane flashing) #1288
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For issue MacDownApp#747, a change was introduced that uses private API to disable caching on the preview pane's web view. This was ostensibly to make it so that if images referenced in the markdown document are changed on disk, their changes are reflected in the preview pane. Unfortunately, perhaps due to some underlying changes to WebKit/WebView, disabling caching will also disable caching for all sorts of other things like stylesheets and the base html document loaded from disk. This results in a momentary flash of empty content if one is typing quickly. Reverting the changes for MacDownApp#747 resolves the flashing issue, but does regress the issue regarding images being persistently cached. However, the flashing issue appears to be bothering more people than the image issue, so I believe it would be appropriate to temporarily regress the image caching bug to resolve the flashing bug. Supposedly, a plan exists to migrate to WKWebView, which would hopefully resolve both of these issues simultaneously.
|
Would be very good to get this in. |
|
Where's the maintainers? :-( |
|
Need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #747, a change was introduced that uses private API to disable
caching on the preview pane's web view. This was ostensibly to make it
so that if images referenced in the markdown document are changed on
disk, their changes are reflected in the preview pane.
Unfortunately, perhaps due to some underlying changes to WebKit/WebView,
disabling caching will also disable caching for all sorts of other
things like stylesheets and the base html document loaded from disk.
This results in a momentary flash of empty content if one is typing
quickly.
Reverting the changes for #747 resolves the flashing issue, but does
regress the issue regarding images being persistently cached.
However, the flashing issue appears to be bothering more people than the
image issue, so I believe it would be appropriate to temporarily regress
the image caching bug to resolve the flashing bug. Supposedly, a plan
exists to migrate to WKWebView, which would hopefully resolve both of
these issues simultaneously.