Implement clearing correctly for ZIP Shrink method#180
Open
chasonr wants to merge 1 commit intoMacPaw:masterfrom
Open
Implement clearing correctly for ZIP Shrink method#180chasonr wants to merge 1 commit intoMacPaw:masterfrom
chasonr wants to merge 1 commit intoMacPaw:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "clear" code for the ZIP Shrink method is not supposed to clear the entire LZW tree, but only the leaf nodes. This change correctly implements the clearing for Shrink.
A Zip that needs this change can be found at http://cd.textfiles.com/garbo/PC/FORMAT/MAXI161.ZIP .
Clearing only leaf nodes can leave the array in a state where the allocated nodes are not contiguous. Some changes to the data structure were necessary to allow this. The free nodes are kept on a linked list, which is built anew whenever the tree is either fully or partially cleared.